Skip to content

Onboard PostgreSQL 18 #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pkhartsk wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Onboard PostgreSQL 18 #641

pkhartsk wants to merge 5 commits into from

Conversation

@pkhartsk
Copy link
Contributor

@pkhartsk pkhartsk commented Jan 8, 2026 •
edited by github-actions bot
Loading

PTAL at how I changed the dist-gen source files. I tried to be as non-intrusive as possible.

@pkhartsk
Copy link
Contributor Author

pkhartsk commented Jan 8, 2026

[test-all]

@github-actions
Copy link

github-actions bot commented Jan 8, 2026 •
edited
Loading

Pull Request validation

Failed

🔴 Approval - missing or changes were requested

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member

@pkhartsk pkhartsk mentioned this pull request Jan 8, 2026
Open
@github-actions
Copy link

github-actions bot commented Jan 8, 2026 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - PyTest - 15Fedora-latestx86_64✅ passed20.01.2026 15:21:125min 11stest pipeline
Fedora - PyTest - 16Fedora-latestx86_64✅ passed20.01.2026 15:22:124min 58stest pipeline
CentOS Stream 10 - PyTest - 16CentOS-Stream-10x86_64✅ passed20.01.2026 14:59:488min 9stest pipeline
CentOS Stream 9 - PyTest - 15CentOS-Stream-9x86_64✅ passed20.01.2026 14:59:489min 36stest pipeline
RHEL10 - PyTest - 16RHEL-10-Nightlyx86_64✅ passed20.01.2026 14:59:4711min 9stest pipeline
RHEL8 - PyTest - 15RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 09:21:5311min 32stest pipeline
CentOS Stream 9 - 13CentOS-Stream-9x86_64✅ passed20.01.2026 15:12:0812min 56stest pipeline
CentOS Stream 9 - 15CentOS-Stream-9x86_64✅ passed20.01.2026 09:07:0112min 57stest pipeline
CentOS Stream 9 - 16CentOS-Stream-9x86_64✅ passed20.01.2026 14:59:4612min 24stest pipeline
RHEL8 - 12RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 09:06:4419min 44stest pipeline
RHEL9 - PyTest - 15RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:00:1816min 30stest pipeline
RHEL9 - Unsubscribed host - PyTest - 13RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 09:06:3722min 11stest pipeline
RHEL8 - 15RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 15:22:3517min 11stest pipeline
RHEL8 - 13RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 14:59:5116min 20stest pipeline
RHEL9 - PyTest - 13RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 14:59:4616min 2stest pipeline
RHEL9 - Unsubscribed host - PyTest - 15RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 14:59:4619min 5stest pipeline
RHEL9 - Unsubscribed host - 16RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:00:0619min 24stest pipeline
Fedora - 15Fedora-latestx86_64✅ passed20.01.2026 15:12:138min 35stest pipeline
RHEL9 - 13RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:28:4219min 36stest pipeline
RHEL9 - Unsubscribed host - PyTest - 16RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:10:2519min 57stest pipeline
RHEL9 - 16RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 09:33:3024min 48stest pipeline
RHEL10 - Unsubscribed host - PyTest - 16RHEL-10-Nightlyx86_64✅ passed20.01.2026 15:19:0910min 25stest pipeline
RHEL8 - PyTest - 16RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 15:16:1311min 30stest pipeline
RHEL8 - PyTest - 13RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 14:59:4611min 40stest pipeline
CentOS Stream 9 - PyTest - 13CentOS-Stream-9x86_64✅ passed20.01.2026 15:10:259min 23stest pipeline
RHEL9 - Unsubscribed host - 13RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 14:59:4617min 50stest pipeline
CentOS Stream 9 - PyTest - 16CentOS-Stream-9x86_64✅ passed20.01.2026 15:20:538min 9stest pipeline
CentOS Stream 10 - 16CentOS-Stream-10x86_64✅ passed20.01.2026 09:33:4910min 45stest pipeline
RHEL8 - PyTest - 12RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 15:22:1711min 18stest pipeline
Fedora - 16Fedora-latestx86_64✅ passed20.01.2026 15:20:188min 33stest pipeline
RHEL9 - Unsubscribed host - 15RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 14:59:4819min 42stest pipeline
RHEL9 - PyTest - 16RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:20:5616min 20stest pipeline
RHEL10 - OpenShift 4 - 16RHEL-10-Nightlyx86_64✅ passed20.01.2026 15:41:0610min 54stest pipeline
RHEL10 - Unsubscribed host - 16RHEL-10-Nightlyx86_64✅ passed20.01.2026 15:24:3013min 46stest pipeline
RHEL10 - 16RHEL-10-Nightlyx86_64✅ passed20.01.2026 15:18:2721min 57stest pipeline
RHEL8 - 16RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 09:33:4219min 57stest pipeline
RHEL8 - OpenShift 4 - 12RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 15:40:5115min 21stest pipeline
RHEL8 - PyTest - OpenShift 4 - 15RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 15:43:0517min 49stest pipeline
RHEL10 - PyTest - OpenShift 4 - 16RHEL-10-Nightlyx86_64✅ passed20.01.2026 15:32:4519min 14stest pipeline
RHEL8 - OpenShift 4 - 16RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 15:30:4214min 59stest pipeline
RHEL8 - OpenShift 4 - 13RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 15:34:3617min 53stest pipeline
RHEL9 - OpenShift 4 - 16RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:30:4416min 5stest pipeline
RHEL9 - 15RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:20:1520min 29stest pipeline
RHEL8 - OpenShift 4 - 15RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 15:43:0815min 1stest pipeline
RHEL8 - PyTest - OpenShift 4 - 12RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 14:04:1317min 31stest pipeline
RHEL8 - PyTest - OpenShift 4 - 16RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 15:31:4317min 22stest pipeline
RHEL9 - OpenShift 4 - 15RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:39:5716min 1stest pipeline
RHEL9 - OpenShift 4 - 13RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:39:1816min 30stest pipeline
RHEL8 - PyTest - OpenShift 4 - 13RHEL-8.10.0-Nightlyx86_64✅ passed20.01.2026 15:43:4617min 36stest pipeline
RHEL9 - PyTest - OpenShift 4 - 13RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:38:4922min 57stest pipeline
RHEL9 - PyTest - OpenShift 4 - 16RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:41:2521min test pipeline
RHEL9 - PyTest - OpenShift 4 - 15RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:34:4426min 10stest pipeline
CentOS Stream 10 - PyTest - 18CentOS-Stream-10x86_64✅ passed20.01.2026 15:12:167min 53stest pipeline
CentOS Stream 9 - 18CentOS-Stream-9x86_64❌ error20.01.2026 14:04:129min 29stest pipeline
CentOS Stream 9 - PyTest - 18CentOS-Stream-9x86_64❌ error20.01.2026 14:04:1410min 7stest pipeline
RHEL10 - 18RHEL-10-Nightlyx86_64✅ passed20.01.2026 15:18:1915min 38stest pipeline
RHEL10 - PyTest - 18RHEL-10-Nightlyx86_64✅ passed20.01.2026 15:12:1410min 39stest pipeline
RHEL10 - Unsubscribed host - PyTest - 18RHEL-10-Nightlyx86_64✅ passed20.01.2026 14:59:4610min 38stest pipeline
Fedora - 18Fedora-latestx86_64✅ passed20.01.2026 15:18:158min 37stest pipeline
RHEL9 - Unsubscribed host - 18RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:06:1525min 18stest pipeline
RHEL9 - PyTest - 18RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 14:59:4616min 47stest pipeline
RHEL9 - 18RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:20:3521min 49stest pipeline
CentOS Stream 10 - 18CentOS-Stream-10x86_64✅ passed20.01.2026 15:27:3311min 60stest pipeline
RHEL9 - Unsubscribed host - PyTest - 18RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 14:59:4820min 10stest pipeline
Fedora - PyTest - 18Fedora-latestx86_64✅ passed20.01.2026 14:59:545min test pipeline
RHEL10 - OpenShift 4 - 18RHEL-10-Nightlyx86_64✅ passed20.01.2026 15:42:5112min 6stest pipeline
RHEL10 - PyTest - OpenShift 4 - 18RHEL-10-Nightlyx86_64✅ passed20.01.2026 15:31:1211min 58stest pipeline
RHEL10 - Unsubscribed host - 18RHEL-10-Nightlyx86_64✅ passed20.01.2026 15:14:1614min 4stest pipeline
RHEL9 - OpenShift 4 - 18RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:29:1116min 22stest pipeline
RHEL9 - PyTest - OpenShift 4 - 18RHEL-9.6.0-Nightlyx86_64✅ passed20.01.2026 15:30:5516min 46stest pipeline

@pkhartsk
Copy link
Contributor Author

pkhartsk commented Jan 8, 2026

[test-all]

@phracek
Copy link
Member

phracek commented Jan 12, 2026

See take an inspiration from #548.

For me it is better to review this huge change.

@pkhartsk pkhartsk force-pushed the onboard-postgresql18 branch from 90c5f6f to 31c20e3 Compare January 12, 2026 11:02
@pkhartsk pkhartsk force-pushed the onboard-postgresql18 branch 3 times, most recently from cf5c2c3 to bbbdf41 Compare January 12, 2026 14:56
@pkhartsk
Copy link
Contributor Author

pkhartsk commented Jan 12, 2026

[test-all]

@pkhartsk pkhartsk requested a review from phracek January 13, 2026 08:31
@pkhartsk
Copy link
Contributor Author

pkhartsk commented Jan 13, 2026

Depends on #643

@pkhartsk
Copy link
Contributor Author

pkhartsk commented Jan 13, 2026

[test-all]

@pkhartsk pkhartsk marked this pull request as ready for review January 13, 2026 09:38
@pkhartsk pkhartsk force-pushed the onboard-postgresql18 branch from bbbdf41 to eb0e20b Compare January 13, 2026 10:58
@pkhartsk
Copy link
Contributor Author

pkhartsk commented Jan 13, 2026

[test-all]

@pkhartsk
Copy link
Contributor Author

pkhartsk commented Jan 13, 2026 •
edited
Loading

Fedora postgresql18 test fails because f43 has the wrong pgaudit. Fix here: https://src.fedoraproject.org/rpms/postgresql18-pgaudit/pull-request/3

CentOS Stream 9 tests fail because the postgresql:18 module isn't there yet.

@pkhartsk pkhartsk force-pushed the onboard-postgresql18 branch from eb0e20b to bbdfc4c Compare January 14, 2026 16:47
@pkhartsk
Copy link
Contributor Author

pkhartsk commented Jan 15, 2026

[test-all]

@pkhartsk pkhartsk force-pushed the onboard-postgresql18 branch from a35ca46 to 1ee57a6 Compare January 20, 2026 09:05
@pkhartsk
Copy link
Contributor Author

pkhartsk commented Jan 20, 2026

[test-all]

phracek
phracek requested changes Jan 20, 2026
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comments. I will look at the tests in the meanwhile.

phracek
phracek requested changes Jan 20, 2026
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update also build-and-push file in .github/workflows directory.

@pkhartsk
Edit dist-gen sources to support postgresql 18
9d963fe
@pkhartsk
Add generated files for postgresql 18
93663d4
@pkhartsk
Fix tests and special character username test
7f31939 
Add URI encoding of user and db name in tests that use the
connection URI to access a container, test that it works with
both spaces and special characters. This is because postgres 18
does not accept spaces in the connection URI but earlier versions do.
@pkhartsk
Disable openshift pytests that require imagestreams to be available
b215437 
Revert this when imagestreams are available
@pkhartsk
Add building and pushing functionality for Fedora and c10s images
97ed698 
c9s should be added when rpms become available
@pkhartsk pkhartsk force-pushed the onboard-postgresql18 branch from 1ee57a6 to 97ed698 Compare January 20, 2026 14:57
@pkhartsk
Copy link
Contributor Author

pkhartsk commented Jan 20, 2026

[test-all]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phracek phracek phracek requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

pr/changes-requested ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pkhartsk @phracek